Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to default PDM #1645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tisnik
Copy link
Contributor

@tisnik tisnik commented Sep 23, 2024

Description

Back to default PDM

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@tisnik
Copy link
Contributor Author

tisnik commented Sep 23, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tisnik. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tisnik
Copy link
Contributor Author

tisnik commented Sep 26, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@tisnik
Copy link
Contributor Author

tisnik commented Sep 30, 2024

/retest

1 similar comment
@tisnik
Copy link
Contributor Author

tisnik commented Oct 4, 2024

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (12c8083) to head (d59fea3).
Report is 82 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
- Coverage   94.88%   92.33%   -2.56%     
==========================================
  Files          60       60              
  Lines        2681     2687       +6     
==========================================
- Hits         2544     2481      -63     
- Misses        137      206      +69     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

Copy link

openshift-ci bot commented Oct 4, 2024

@tisnik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ols-cluster-4-16 d59fea3 link true /test e2e-ols-cluster-4-16
ci/prow/e2e-ols-cluster-4-15 d59fea3 link true /test e2e-ols-cluster-4-15
ci/prow/e2e-ols-cluster-4-17 d59fea3 link true /test e2e-ols-cluster-4-17
ci/prow/integration d59fea3 link true /test integration
ci/prow/verify d59fea3 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants