Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-1055: switch to gpt-4o-mini #1725

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Oct 8, 2024

Description

wip

Type of change

  • New feature

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@onmete: This pull request references OLS-1055 which is a valid jira issue.

In response to this:

Description

wip

Type of change

  • New feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh October 8, 2024 10:41
Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tisnik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tests/e2e/test_api.py Outdated Show resolved Hide resolved
@onmete
Copy link
Contributor Author

onmete commented Oct 8, 2024

/test e2e-ols-cluster-4-15

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (3141272) to head (508e357).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   94.90%   94.90%   -0.01%     
==========================================
  Files          60       60              
  Lines        2689     2688       -1     
==========================================
- Hits         2552     2551       -1     
  Misses        137      137              
Files with missing lines Coverage Δ
ols/app/models/models.py 100.00% <ø> (ø)
ols/constants.py 100.00% <100.00%> (ø)
ols/src/llms/llm_loader.py 100.00% <ø> (ø)
ols/src/prompts/prompts.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@onmete
Copy link
Contributor Author

onmete commented Oct 8, 2024

/test e2e-ols-cluster-4-15

@onmete
Copy link
Contributor Author

onmete commented Oct 9, 2024

/test e2e-ols-cluster-4-15

Copy link

openshift-ci bot commented Oct 9, 2024

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ols-cluster-4-17 508e357 link true /test e2e-ols-cluster-4-17
ci/prow/e2e-ols-cluster-4-15 508e357 link true /test e2e-ols-cluster-4-15
ci/prow/e2e-ols-cluster-4-16 508e357 link true /test e2e-ols-cluster-4-16

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants