Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konflux: fix hermetic build argument #1731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 8, 2024

Description

Turn on hermetic builds in Konflux

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh October 8, 2024 21:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (3141272) to head (9bd1b5d).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          60       60           
  Lines        2689     2689           
=======================================
  Hits         2552     2552           
  Misses        137      137           

see 1 file with indirect coverage changes

@xrajesh
Copy link
Contributor

xrajesh commented Oct 8, 2024

/test e2e-ols-cluster-4-15

@syedriko syedriko force-pushed the syedriko-hermetic-arg-fix branch 2 times, most recently from 028fe07 to 587c2b7 Compare October 9, 2024 02:27
@raptorsun
Copy link
Contributor

/lgtm

@raptorsun
Copy link
Contributor

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@raptorsun
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Oct 9, 2024

@raptorsun: raptorsun unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raptorsun raptorsun mentioned this pull request Oct 9, 2024
14 tasks
@tisnik
Copy link
Contributor

tisnik commented Oct 9, 2024

/approve

Copy link

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b171f86 and 2 for PR HEAD 9bd1b5d in total

Copy link

openshift-ci bot commented Oct 9, 2024

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants