-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-38869: MCN are not updated when we use OCL #4579
base: master
Are you sure you want to change the base?
OCPBUGS-38869: MCN are not updated when we use OCL #4579
Conversation
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-gcp-op-single-node |
2 similar comments
/test e2e-gcp-op-single-node |
/test e2e-gcp-op-single-node |
8a75719
to
d08769f
Compare
LGTM |
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dkhater-redhat Hello! We have problems installing the images created for the PRs (all the PRs not only this one). Nevertheless, nightly builds are installing without problems. Could you please merge this PR? we will test it post-merge in the nightly build. Thanks!! We don't add the qe-approved label since it will verified post-merge. |
/retest-required |
/jira refresh |
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- What I did
Fixed a bug in
updateOnClusterBuild
where mcn's were not correctly updating their.spec.configVersion.desired
field when using ocl. The fix involved leveraging the GenerateAndApplyMachineConfigNodeSpec function to ensure that the MCNs are correctly updated with the latest desired configuration after applying a new MachineConfig.- How to verify it
.spec.configVersion.desired
field of mcn's reflects the updated mc across all nodes in the worker pool.- Description for the changelog
Fixed an issue where mcn's were not updating their
.spec.configVersion.desired
field correctly when using ocl in the mcd