Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS #2226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update OWNERS #2226

wants to merge 1 commit into from

Conversation

renan-campos
Copy link
Contributor

@renan-campos renan-campos commented Sep 18, 2024

The user renan-campos is responsible for the reviewing the definitions related to WifTemplates, which is a component for a new type of OSD GCP deployment.

What type of PR is this?

(bug/feature/cleanup/documentation)
feature

What this PR does / why we need it?

So I can review and merge changes to Wif Templates in a timely manner.

Which Jira/Github issue(s) this PR fixes?

XCMSTRAT-48

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

The user renan-campos is responsible for the reviewing the definitions related to WifTemplates, which is a component for a new type of OSD GCP deployment.
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renan-campos
Once this PR has been reviewed and has the lgtm label, please assign robotmaxtron for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@renan-campos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cblecker
Copy link
Member

You're talking about the resources/wif directory, right? You can create an OWNERS file for that directory without granting access to the whole repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants