Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Data Clerk fixes #2654

Merged
merged 6 commits into from
Aug 14, 2023
Merged

[MWCore] Data Clerk fixes #2654

merged 6 commits into from
Aug 14, 2023

Conversation

sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2654 (a770877) into mwcore-dev (5a62272) will increase coverage by 0.1%.
The diff coverage is 60.0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2654     +/-   ##
==============================================
+ Coverage          67.5%   67.6%   +0.1%     
- Complexity          877     880      +3     
==============================================
  Files               160     160             
  Lines              7126    7129      +3     
  Branches            991     991             
==============================================
+ Hits               4815    4826     +11     
+ Misses             1687    1679      -8     
  Partials            624     624             
Flag Coverage Δ
engine 67.6% <60.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...egister/fhircore/engine/ui/login/LoginViewModel.kt 80.1% <0.0%> (ø)
...ircore/engine/ui/appsetting/AppSettingViewModel.kt 45.4% <100.0%> (+11.6%) ⬆️

... and 1 file with indirect coverage changes

@sevenreup sevenreup marked this pull request as ready for review August 14, 2023 07:26
@sevenreup sevenreup merged commit 6080e14 into mwcore-dev Aug 14, 2023
4 checks passed
@sevenreup sevenreup deleted the dataclerk-fixes branch August 14, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants