Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the SDC Location picker widget to the main branch #3046

Merged
merged 15 commits into from
Mar 15, 2024

Conversation

AbdulWahabMemon
Copy link
Contributor

@AbdulWahabMemon AbdulWahabMemon commented Feb 7, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #880

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 29.8%. Comparing base (ad3a737) to head (992b993).
Report is 200 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3046      +/-   ##
==========================================
- Coverage     64.5%   29.8%   -34.8%     
+ Complexity    1075     652     -423     
==========================================
  Files          218     236      +18     
  Lines         9635   11086    +1451     
  Branches      1897    1929      +32     
==========================================
- Hits          6218    3306    -2912     
- Misses        2234    7350    +5116     
+ Partials      1183     430     -753     
Flag Coverage Δ
geowidget 47.2% <ø> (-17.1%) ⬇️
quest 5.2% <0.0%> (-53.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/engine/util/helper/TransformSupportServices.kt 74.1% <0.0%> (-8.6%) ⬇️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 4.1% <0.0%> (-24.3%) ⬇️
...temViewHolderFactoryMatchersProviderFactoryImpl.kt 0.0% <0.0%> (ø)

... and 125 files with indirect coverage changes

* main:
  Add icons to be displayed on eusm service point register. (#3047)
  Upgrade sdk libraries to latest versions (#2825)
  Make Login Screen Logo Size Configurable (#3045)

# Conflicts:
#	android/gradle/libs.versions.toml
#	android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt
android/build.gradle.kts Outdated Show resolved Hide resolved
* main:
  update admin-dashboard-feature docs (#3084)
  eir demo flavor (#3102)
  Use subject's Related Entity Location meta tag on related resources (#3097)
@dubdabasoduba dubdabasoduba changed the title cherry pick location-widget-0-2-5 sample Add Location picker widget to the main branch Feb 27, 2024
@dubdabasoduba dubdabasoduba changed the title Add Location picker widget to the main branch Add the SDC Location picker widget to the main branch Feb 27, 2024
LZRS
LZRS previously approved these changes Feb 28, 2024
@dubdabasoduba dubdabasoduba merged commit fa44073 into main Mar 15, 2024
3 of 5 checks passed
@dubdabasoduba dubdabasoduba deleted the main-lw-sample branch March 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Location Widget (a.k.a GPS picker) to FHIR Core
7 participants