Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app title visibility configurable in LoginScreen #3063

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

hamza-vd
Copy link
Contributor

@hamza-vd hamza-vd commented Feb 13, 2024

This PR will make app title visibility configurable in LoginScreen. This is something that was required for the mockup mentioned in this ticket

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (cd02814) 29.9%.
Report is 171 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3063      +/-   ##
==========================================
- Coverage     64.5%   29.9%   -34.6%     
+ Complexity    1075     650     -425     
==========================================
  Files          218     236      +18     
  Lines         9635   10925    +1290     
  Branches      1897    1897              
==========================================
- Hits          6218    3273    -2945     
- Misses        2234    7231    +4997     
+ Partials      1183     421     -762     
Flag Coverage Δ
engine 66.1% <ø> (-6.6%) ⬇️
geowidget 47.2% <ø> (-17.1%) ⬇️
quest 5.3% <0.0%> (-53.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...artregister/fhircore/quest/ui/login/LoginScreen.kt 0.0% <0.0%> (-68.7%) ⬇️

... and 126 files with indirect coverage changes

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamza-vd can you please add a test to LoginScreen for this?

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ndegwamartin ndegwamartin merged commit 7b04c19 into main Feb 19, 2024
3 of 5 checks passed
@ndegwamartin ndegwamartin deleted the hide-app-title branch February 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants