Add Exit Dialog #3487
Merged
Add Exit Dialog #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=========================================
- Coverage 27.2% 27.2% -0.1%
Complexity 756 756
=========================================
Files 278 278
Lines 14219 14234 +15
Branches 2581 2582 +1
=========================================
+ Hits 3880 3881 +1
- Misses 9801 9815 +14
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ellykits
requested changes
Sep 12, 2024
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/main/AppMainActivity.kt
Outdated
Show resolved
Hide resolved
|
Dialog content 
|
# Conflicts: # android/quest/src/main/res/values/strings.xml
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/main/AppMainActivity.kt
Outdated
Show resolved
Hide resolved
ellykits
reviewed
Oct 4, 2024
Comment on lines
315
to
318
| if ( | ||
| navController.currentDestination?.id?.equals(R.id.geoWidgetLauncherFragment)!! || | ||
| navController.currentDestination?.id?.equals(R.id.registerFragment)!! | ||
| ) { |
There was a problem hiding this comment.
I understand this implementation is based on the assumption that the entry point to the app can either be the map or register. However, a user can redirect to a register screen from the profile using the onSubmitQuestionnaire actions. Would it be possible to check if there is no more entry in the navController back stack instead to prompt this dialog?
ellykits
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3479
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile