-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exporter #90
Added exporter #90
Conversation
At which stage the quality assessment of this new feed will be checked (against current one)? |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 17 +2
Lines 544 567 +23
=========================================
+ Hits 544 567 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
Also, there's a conflict that you should look into (rebase from master) as nobody else works on this.
I'll add a ticket to add a trigger for this as we'll need to test this live as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we agreed on testing the check_and_upload_file
call in the tests like missing file to upload or incorrect UPLOAD_URI
.
I also notice that there are warnings in the tests output regarding calls that were not awaited. This should be fixed (although it may originate from previous code).
Making sure upload status is reported is important ; see inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ; it's almost there but we need to test that common problems (namely our inputs) are caught, otherwise tests are not as useful:
- incorrect URL should fail
- incorrect RSA key should fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment ; either the test or its name is incorrect
Fixes #77