Correctly try to open split files. #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
force-pushed
the
split_file_open
branch
from
452bb07
to
917ad90
Compare
veloman-yunkan
requested changes
Apr 28, 2024
mgautierfr
force-pushed
the
split_file_open
branch
from
917ad90
to
9bf60d8
Compare
|
It appears that the first commit is a bit too aggressive (without speaking potential ABI break). See https://github.com/openzim/libzim/actions/runs/8882043713/job/24385796413?pr=880 I have propose another PR #881 simply testing creation of |
veloman-yunkan
requested changes
Apr 29, 2024
mgautierfr
force-pushed
the
split_file_open
branch
3 times, most recently
from
2bdffb0
to
e028dc5
Compare
Done |
veloman-yunkan
requested changes
Apr 30, 2024
mgautierfr
force-pushed
the
split_file_open
branch
from
e028dc5
to
6348ae4
Compare
One is for simple file part only, the other is for multi part only. We also introduce a static helper function `openSinglePieceOrSplitFile` to build the FileCompound as before. This helper function is put in FileImpl which can seem a bit odd but will simplify next commits.
mgautierfr
force-pushed
the
split_file_open
branch
from
6348ae4
to
91f78bb
Compare
|
New version (simpler) following your live advice. |
veloman-yunkan
approved these changes
Apr 30, 2024
…opening. Now, it tries to open as single piece only if not ending by `.zimaa`. If it cannot find the file, or if ending with `.zimaa`, it tries multi zim part. In any case, FileImpl constructor check for size and throw a ZimFileFormatError is file's size doesn't correspond to what is the header.
mgautierfr
force-pushed
the
split_file_open
branch
from
91f78bb
to
48e64c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #879
First commit is not really related to this PR but recent gcc complain about the missing default destructor in
test/archive.cpp. So I fix this in the same time. If you prefer, I can move it a different PR as it is not straightforward fix.