Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when failin to open (split) zim file. #884

Merged
merged 1 commit into from
May 2, 2024
Merged

Better error message when failin to open (split) zim file. #884

merged 1 commit into from
May 2, 2024

Conversation

mgautierfr
Copy link
Collaborator

Fix #883

github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2024
View reviewed changes
.github/workflows/ci.yml Fixed Show fixed Hide fixed
kelson42
kelson42 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a user POV

@mgautierfr mgautierfr merged commit 59e9a39 into main May 2, 2024
34 checks passed
@mgautierfr mgautierfr deleted the better_error_message branch May 2, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelson42 kelson42 kelson42 approved these changes

@veloman-yunkan veloman-yunkan veloman-yunkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message is slightly misleading if ZIM file can not be open
3 participants
@mgautierfr @kelson42 @veloman-yunkan