Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

feat: remove provider #52

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: remove provider #52

wants to merge 6 commits into from

Conversation

shamb0t
Copy link
Contributor

@shamb0t shamb0t commented Nov 18, 2019

Removes provider from identity

Supersedes #49

haadcode
haadcode reviewed Nov 18, 2019
View reviewed changes
test/identity.spec.js Outdated Show resolved Hide resolved
@haadcode
Copy link
Member

LGTM 👍

@haadcode
Copy link
Member

@shamb0t does this PR supersede #49?

@shamb0t
Copy link
Contributor Author

shamb0t commented Nov 18, 2019

Thanks @haadcode and yes it does 👍

@shamb0t shamb0t mentioned this pull request Nov 18, 2019
Closed
@haadcode
Copy link
Member

Fixes #48.

aphelionz
aphelionz reviewed Nov 18, 2019
View reviewed changes
src/identities.js Outdated Show resolved Hide resolved
src/identities.js Outdated Show resolved Hide resolved
@shamb0t
use path.join
ad74d3e 
compact provider creation
@aphelionz aphelionz mentioned this pull request Nov 19, 2019
Merged
5 tasks
@aphelionz
Copy link
Contributor

LGTM 👍

@aphelionz aphelionz added this to Backlog / Triage in Release 0.25.0 May 30, 2020
@aphelionz aphelionz removed this from Backlog / Triage in Release 0.25.0 Aug 24, 2020
@aphelionz aphelionz added this to Triage in Release 0.25.2 Aug 24, 2020
@haadcode haadcode removed this from Triage in Release 0.25.2 Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aphelionz aphelionz aphelionz left review comments

@haadcode haadcode haadcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shamb0t @haadcode @aphelionz