HTML/SVG code preview #3259
Draft
HTML/SVG code preview #3259
+56
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ord io and Geniidata both have a code preview on the inscription pages for html and svg. This would be a nice feature for the inscription page.
We can use the highlight Js with the XML to hightlight HTML and SVG. I initialized a new code-preview template.
We could swap the Iframe of the html preview with the html code preview. However we try and minimize client JS so maybe there is a different way of doing it? Open to suggestions.
PR is far from working just throwing down some ideas