LP Tests #72
Open
LP Tests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test to effects of PR #70, I've added a codegen test where
PisNone. This would have failed on Windows before PR #70 but should pass now. SpecifyingPasNoneand later updating to a non-None value using theupdate_Pmethod does not seem to be supported, so I'm only testing some other cases here -solve,update_Aetc.While I was at it, I noticed that the codegen tests were relying on the fact that
test_solvewill be executed before any other tests (test_update_*). This is not guaranteed but is probably only happening because tests are picked up in alphabetic order, so I've moved the codegen logic to the class method, and am re-setting the model insetUp.Also enabled codegen checks on the CI.