Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use outlines.processors for models.llamacpp #997

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use outlines.processors for models.llamacpp #997

wants to merge 3 commits into from

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Jun 21, 2024 •
edited
Loading

Awaiting #998

Fixes #965

Problem

in main

  • generate.fsm only supports SequenceGenerator,
  • models.llamacpp doesn't support SequenceGenerator, it only supports SequenceGeneratorAdapter
  • integrations.llamacpp doesn't have a FSM logits processor.

Solution

  • Ensure models.llamacpp uses outlines.processors / SequenceGeneratorAdapter for all generators
  • Update generate.fsm to use SequenceGeneratorAdapter for all unified models
  • outlines.generate.fsm integration tests for all unified models

@lapp0 lapp0 mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lapp0 lapp0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LlamaCpp doesnt work with generate.fsm for custom FSMs
1 participant
@lapp0