feat(linter): add @typescript-eslint/consistent-type-imports rule

oxc-project · Jun 30, 2024 · 2e7389d · 2e7389d
1 parent 9bc36ed
commit 2e7389d
Show file tree

Hide file tree

Showing 4 changed files with 3,211 additions and 10 deletions.
diff --git a/crates/oxc_ast/src/ast_impl/js.rs b/crates/oxc_ast/src/ast_impl/js.rs
@@ -1374,19 +1374,16 @@ impl AccessorPropertyType {
 }
 
 impl<'a> ImportDeclarationSpecifier<'a> {
-    pub fn name(&self) -> CompactStr {
+    pub fn local(&self) -> &BindingIdentifier<'a> {
         match self {
-            ImportDeclarationSpecifier::ImportSpecifier(specifier) => {
-                specifier.local.name.to_compact_str()
-            }
-            ImportDeclarationSpecifier::ImportNamespaceSpecifier(specifier) => {
-                specifier.local.name.to_compact_str()
-            }
-            ImportDeclarationSpecifier::ImportDefaultSpecifier(specifier) => {
-                specifier.local.name.to_compact_str()
-            }
+            ImportDeclarationSpecifier::ImportSpecifier(specifier) => &specifier.local,
+            ImportDeclarationSpecifier::ImportNamespaceSpecifier(specifier) => &specifier.local,
+            ImportDeclarationSpecifier::ImportDefaultSpecifier(specifier) => &specifier.local,
         }
     }
+    pub fn name(&self) -> CompactStr {
+        self.local().name.to_compact_str()
+    }
 }
 
 impl<'a> ImportAttributeKey<'a> {

diff --git a/crates/oxc_linter/src/rules.rs b/crates/oxc_linter/src/rules.rs
@@ -129,6 +129,7 @@ mod typescript {
     pub mod ban_types;
     pub mod consistent_indexed_object_style;
     pub mod consistent_type_definitions;
+    pub mod consistent_type_imports;
     pub mod explicit_function_return_type;
     pub mod no_duplicate_enum_values;
     pub mod no_empty_interface;
@@ -524,6 +525,7 @@ oxc_macros::declare_all_lint_rules! {
     typescript::prefer_enum_initializers,
     typescript::ban_types,
     typescript::consistent_type_definitions,
+    typescript::consistent_type_imports,
     typescript::consistent_indexed_object_style,
     typescript::no_duplicate_enum_values,
     typescript::no_empty_interface,