Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NormalList and SeparatedList trait implementation with parseDelimitedList and parseList #3887

Closed
Boshen opened this issue Jun 24, 2024 · 0 comments · Fixed by #4028
Closed

Replace NormalList and SeparatedList trait implementation with parseDelimitedList and parseList #3887

Boshen opened this issue Jun 24, 2024 · 0 comments · Fixed by #4028
Labels
C-enhancement Category - New feature or request

Comments

@Boshen
Copy link
Member

Boshen commented Jun 24, 2024 •
edited
Loading

I find parseDelimitedList and parseList from typescript's parser.ts a lot nicer than our trait implementations, our version is too boilerplate heavy.
@Boshen Boshen added the C-enhancement Category - New feature or request label Jun 24, 2024
This was referenced Jun 24, 2024
Merged
Closed
Boshen added a commit that referenced this issue Jul 1, 2024
@Boshen
refactor(parser): use function instead of trait to parse normal lists
d5bd9f5 
To reduce boilerplate and code noise.

relates #3887
@Boshen Boshen mentioned this issue Jul 1, 2024
Merged
Boshen added a commit that referenced this issue Jul 1, 2024
@Boshen
refactor(parser): use function instead of trait to parse normal lists (…
d0eac46 
…#4003)

To reduce boilerplate and code noise.

relates #3887
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse delimited lists
0e2d1f1 
closes #3887
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse delimited lists
4f997b4 
closes #3887
@Boshen Boshen mentioned this issue Jul 2, 2024
Merged
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse delimited lists
aa30245 
closes #3887
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse delimited li…
1dacb1f 
…sts (#4014)

relates #3887

The rest of the list parsing trait implementations involves ... parsing
`rest`, which I'll refactor in another PR.
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse list with re…
3945397 
…st element

closes #3887
@Boshen Boshen mentioned this issue Jul 2, 2024
Merged
Boshen added a commit that referenced this issue Jul 2, 2024
@Boshen
refactor(parser): use function instead of trait to parse list with re…
243c9f3 
…st element (#4028)

closes #3887
@Boshen Boshen closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(parser): use function instead of trait to parse list with rest element oxc-project/oxc
1 participant
@Boshen