Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NIS currency #13

Merged
merged 3 commits into from
Jul 8, 2024
Merged

feat: add NIS currency #13

merged 3 commits into from
Jul 8, 2024

Conversation

Araxeus
Copy link
Contributor

@Araxeus Araxeus commented Jul 1, 2024

NIS = New Israeli Shekel

Note

This project lacks basic typescript .d.ts declaration file

@ozgurg
Copy link
Owner

ozgurg commented Jul 8, 2024

Thanks for the contribution, and sorry for the delay.

According to Wikipedia, NIS is a non-ISO 4217 currency, but Google supports it (https://www.google.com/search?q=1+USD+to+NIS). So, we can add it.

I'll also add other non-ISO 4217 currencies, and then I'll merge this pull request.

Thanks again! This was the first contribution to this repo. 😊

@ozgurg ozgurg merged commit ff26354 into ozgurg:main Jul 8, 2024
@ozgurg
Copy link
Owner

ozgurg commented Jul 8, 2024

Oh, I forgot. TypeScript definitions are not my priority currently because JSDoc will be sufficient for now. I will look into it when I have more time. I'm always open to contributions. :)

@Araxeus
Copy link
Contributor Author

Araxeus commented Jul 8, 2024

Anyone importing this package from a typescript file will get errors because of missing type declaration, and its very annoying to deal with

Typescript is very popular today, so it makes sense for a library to provide basic definition files :)

@ozgurg
Copy link
Owner

ozgurg commented Jul 8, 2024

Anyone importing this package from a typescript file will get errors because of missing type declaration, and its very annoying to deal with

Typescript is very popular today, so it makes sense for a library to provide basic definition files :)

I'm using TypeScript as well. I'll keep that in mind for future updates. Thanks again! 👍

@ozgurg ozgurg mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants