Mapping of size or offsets larger than 2GB on a 64 bit system #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the parameters for map read from JavaScript where explicitely set to int only 2GB could be used for either size or offset even on a 64bit system. The type off_t automatically maps to a int32_t on 32 bit systems and int64_t on 64 bit. The original size_t maps to unsigned which would have been more appropriate but NAN does not contain an unsigned type for 64bit.
|
@mattgol if you want to make this PR against https://github.com/Widdershin/mmap-io I'd be willing to include it. |
|
@Widdershin Thanks for taking over maintenance. I'll post the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the parameters for map read from JavaScript where explicitely set to
int only 2GB could be used for either size or offset even on a 64bit system.
The type off_t automatically maps to a int32_t on 32 bit systems and
int64_t on 64 bit. The original size_t maps to unsigned which
would have been more appropriate but NAN does not contain an
unsigned type for 64bit.