BUG: Allow show_versions to work for any module that raises an exception #59114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke I think it may be a while until we do a 3.0 release, and with numpy 2.0 now released, we might be seeing more reports of problems with |
|
OK we can backport this change just in case |
|
Merging, but happy to follow up if needed |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 1, 2024
…y module that raises an exception
mroeschke
added a commit
that referenced
this pull request
Jul 1, 2024
…for any module that raises an exception) (#59158) Backport PR #59114: BUG: Allow show_versions to work for any module that raises an exception Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_versions()broken with pandas 2.2.2 and numpy 2.0 #59110 (Replace xxxx with the GitHub issue number)The use of
import_optional_dependencyonly can ignoreImportError, but as seen in the issue essentially any exception can be raised with an import.Also cleans up some redundancy of optional dependencies being listed.