Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved RESULT ennum successful string #56

Closed
wants to merge 1 commit into from

Conversation

LouisDesdoigts
Copy link

Closes #55

@patrick-kidger
Copy link
Owner

I'm not sure what's causing the test failure, as I can't reproduce it locally. (Even setting the same seed etc.) So I think we can ignore that for now.

I have however realised that this change will break Optimistix: right now, eqx.Enumerations check that you don't change a message when subclassing, and now optimistix.RESULTS.successful will try to change it back to an empty string. (As optimistix.RESULTS subclasses lineax.RESULTS.)

I'm going to downgrade that to a warning. Once the next Equinox release is out, I'll merge this.

@patrick-kidger
Copy link
Owner

Coming back around, I'm afraid that I'm going to close this as a 'wontfix'. :(
It ends up being a little bit annoying to change this, and then propagate the changed result across the ecosystem, in a way that won't spam everyone with errors and warnings. Doable, but probably not worth the hassle.

Thank you anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous output from successful solution using lineax.RESULTS
2 participants