insure int type for math.factorial #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.python.org/issue37315 Accepting floats for math.factorial was removed. since d is either even or manipulated to be even, it should be safe to convert to an integer. https://stackoverflow.com/questions/21753841/factorial-in-numpy-and-scipy math.factorial and np.math.factorial is the same thing
|
Hi, sorry, I somehow missed this PR earlier. I also just did major code refactoring - feel free to re-open this to be in sync with updated master brach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37315
Accepting floats for math.factorial was removed. since d is either even or manipulated to be even, it should be safe to convert to an integer.
https://stackoverflow.com/questions/21753841/factorial-in-numpy-and-scipy
math.factorial and np.math.factorial is the same thing