Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image in CI #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JakobMiksch
Copy link
Contributor

  • fixes QSA-api Docker #46
  • this PR builds a docker image when a new version (according to semantic versioning) is released
  • currently the image is published to GitHub container registry. However we could adapt it to publish it alternatively to DockerHub (or maybe both)
  • the GH Action "docker/metadata-action" extracts multiple Docker tags and labels per release, based on semantic versioning. example v1.2.3 would create these tags:
    • latest
    • 1
    • 1.2
    • 1.2.3
  • I adapted the docs, @pblottiere let me know if I should add more
  • I moved the Dockerfile from "sandbox" to the root of the project to give it an more official character. The "compose" file in "sandbox" is adapted and should work as before.

@pblottiere
Copy link
Owner

Hello @JakobMiksch,

Nice, thanks a lot for your PR 👍.

this PR builds a docker image when a new version (according to semantic versioning) is released

What do you think about creating a new docker image for the main branch too?

@JakobMiksch
Copy link
Contributor Author

Creating a docker image from the main branch would useful for testing. So +1 from my side.
We would need to decide which tags we give to these unstable/development images then. Maybe just dev, we could also add the commit hash as image tag. This gives us the possibility to switch back to older development versions.
I can implement this as well. Alternatively we can implement this in a follow-up PR as well.
What do you think, how would you imagine this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants