Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BISERVER-14214] and [BISERVER-14215] Restrict logconfig APIs to administrator and enable by default #4377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cdeptula
Copy link

No description provided.

@wingman-pentaho
Copy link
Collaborator

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl 'extensions' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'extensions' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  assemblies/pentaho-solutions/src/main/resources/pentaho-solutions/system/pentahoServices.spring.xml
  extensions/src/main/java/org/pentaho/platform/web/http/api/resources/Log4jResource.java
  extensions/src/test/java/org/pentaho/platform/web/http/api/resources/Log4jResourceTest.java

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes (click to expand)
org.pentaho.platform.web.http.api.resources.Log4jResource
  • Instruction Change: -6.4% 🔻
  • Line Change: -5% 🔻

1 similar comment
@wingman-pentaho
Copy link
Collaborator

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl 'extensions' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'extensions' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  assemblies/pentaho-solutions/src/main/resources/pentaho-solutions/system/pentahoServices.spring.xml
  extensions/src/main/java/org/pentaho/platform/web/http/api/resources/Log4jResource.java
  extensions/src/test/java/org/pentaho/platform/web/http/api/resources/Log4jResourceTest.java

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes (click to expand)
org.pentaho.platform.web.http.api.resources.Log4jResource
  • Instruction Change: -6.4% 🔻
  • Line Change: -5% 🔻

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy
Copy link
Collaborator

❌ Build failed in 7m 20s

Build command:

mvn clean verify -B -e -Daudit -amd -pl \
assemblies/pentaho-solutions,extensions

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants