-
Please create a issue first and then attach that issue to the PR, so that every one know what’s the need of the PR. Attaching issues to the PR using github keywords, will close the issues once the PR is merged. More info here.
-
Please follow a common git commit style guide. Somewhat similar to this guide
-
All PRs should be Rebase And Merged
- Every thing should be visible at the end of day (Golden rule)
- Architecture - create architecture of the program before starting it, lay down all the entities. Define CRUD operations for these entities, create components around these entities.
- GitHub - create guidelines for commit messages. Create separate environment for staging and production. Always rebase your branch. Every pull request should solve an single issue. Issue must be created before any pull request and should be closed after the issue is fixed. All discussions should be done on issues.
- Slack - Every day standups, weekly loom videos, no private messages conversation, always be in public so that any one can improve or put his points into the arguments.
- Testing - follow tdd as much as possible. There is no need for tests for presentational components, tesrs are only required for container components
- Latest and stable - like Babel, import/ export, class variables.
- Documentation (on README)
- Abstraction- things which are common throuhout the app should be abstracted like buttons, forms, inputs
- Gifs/ video for frontend prs.
- Review each other PRs.
- don’t commit in someone else's pr