refactor: replace right/left with inline corresponding values for better RTL support
#560
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -664,17 +664,14 @@ section { | |
| .container, | ||
| .container-fluid { | ||
| width: 100%; | ||
| margin-inline: auto; | ||
| padding-inline: var(--pico-spacing); | ||
| } | ||
|
|
||
| @media (min-width: 576px) { | ||
| .container { | ||
| max-width: 510px; | ||
| padding-inline: 0; | ||
| } | ||
| } | ||
| @media (min-width: 768px) { | ||
|
|
@@ -847,8 +844,6 @@ blockquote { | |
| display: block; | ||
| margin: var(--pico-typography-spacing-vertical) 0; | ||
| padding: var(--pico-spacing); | ||
| border-inline-start: 0.25rem solid var(--pico-blockquote-border-color); | ||
| border-inline-end: none; | ||
| } | ||
|
|
@@ -1108,7 +1103,6 @@ td { | |
| background-color: var(--pico-background-color); | ||
| color: var(--pico-color); | ||
| font-weight: var(--pico-font-weight); | ||
|
There was a problem hiding this comment.
|
||
| text-align: start; | ||
| } | ||
|
|
||
|
|
@@ -1429,8 +1423,6 @@ label[aria-disabled=true] input[disabled] { | |
| [type=time], | ||
| [type=week], | ||
| [type=range])[aria-invalid] { | ||
|
Comment on lines
-1432
to
-1433
|
||
| padding-inline-start: var(--pico-form-element-spacing-horizontal) !important; | ||
| padding-inline-end: calc(var(--pico-form-element-spacing-horizontal) + 1.5rem) !important; | ||
| background-position: center right 0.75rem; | ||
|
|
@@ -1500,8 +1492,6 @@ select::-ms-expand { | |
| background-color: transparent; | ||
| } | ||
| select:not([multiple], [size]) { | ||
| padding-inline-start: var(--pico-form-element-spacing-horizontal); | ||
| padding-inline-end: calc(var(--pico-form-element-spacing-horizontal) + 1.5rem); | ||
| background-image: var(--pico-icon-chevron); | ||
|
|
@@ -1707,7 +1697,7 @@ label:has([type=checkbox], [type=radio]) { | |
| input:not([type=checkbox], [type=radio], [type=range], [type=file]):is([type=date], [type=datetime-local], [type=month], [type=time], [type=week]) { | ||
| --pico-icon-position: 0.75rem; | ||
| --pico-icon-width: 1rem; | ||
| padding-inline-end: calc(var(--pico-icon-width) + var(--pico-icon-position)); | ||
| background-image: var(--pico-icon-date); | ||
| background-position: center right var(--pico-icon-position); | ||
| background-size: var(--pico-icon-width) auto; | ||
|
|
@@ -1723,8 +1713,8 @@ input:not([type=checkbox], [type=radio], [type=range], [type=file])[type=time] { | |
| [type=time]::-webkit-calendar-picker-indicator, | ||
| [type=week]::-webkit-calendar-picker-indicator { | ||
| width: var(--pico-icon-width); | ||
| margin-inline-start: var(--pico-icon-position); | ||
| margin-inline-end: calc(var(--pico-icon-width) * -1); | ||
| opacity: 0; | ||
| } | ||
|
|
||
|
|
@@ -1734,28 +1724,28 @@ input:not([type=checkbox], [type=radio], [type=range], [type=file])[type=time] { | |
| [type=month], | ||
| [type=time], | ||
| [type=week] { | ||
| padding-inline-end: var(--pico-form-element-spacing-horizontal) !important; | ||
| background-image: none !important; | ||
| } | ||
| } | ||
| [dir=rtl] :is([type=date], [type=datetime-local], [type=month], [type=time], [type=week]) { | ||
| text-align: start; | ||
|
There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| /** | ||
| * Input type file | ||
| */ | ||
| [type=file] { | ||
| --pico-color: var(--pico-muted-color); | ||
| margin-inline-start: calc(var(--pico-outline-width) * -1); | ||
| padding: calc(var(--pico-form-element-spacing-vertical) * 0.5) 0; | ||
| padding-inline-start: var(--pico-outline-width); | ||
| border: 0; | ||
| border-radius: 0; | ||
| background: none; | ||
| } | ||
| [type=file]::file-selector-button { | ||
| margin-inline-end: calc(var(--pico-spacing) / 2); | ||
| padding: calc(var(--pico-form-element-spacing-vertical) * 0.5) var(--pico-form-element-spacing-horizontal); | ||
| } | ||
| [type=file]:is(:hover, :active, :focus)::file-selector-button { | ||
|
|
@@ -1909,7 +1899,7 @@ details summary::after { | |
| width: 1rem; | ||
| height: 1rem; | ||
| margin-inline-start: calc(var(--pico-spacing, 1rem) * 0.5); | ||
| float: inline-end; | ||
| transform: rotate(-90deg); | ||
| background-image: var(--pico-icon-chevron); | ||
| background-position: right center; | ||
|
|
@@ -1931,7 +1921,7 @@ details summary:focus-visible:not([role]) { | |
| } | ||
| details summary[role=button] { | ||
| width: 100%; | ||
| text-align: start; | ||
| } | ||
| details summary[role=button]::after { | ||
| height: calc(1rem * var(--pico-line-height, 1.5)); | ||
|
|
@@ -1947,10 +1937,9 @@ details[open] > summary::after { | |
| } | ||
|
|
||
| [dir=rtl] details summary { | ||
| text-align: start; | ||
| } | ||
| [dir=rtl] details summary::after { | ||
| background-position: left center; | ||
| } | ||
|
|
||
|
|
@@ -1966,17 +1955,17 @@ article { | |
| } | ||
| article > header, | ||
| article > footer { | ||
| margin-inline-start: calc(var(--pico-block-spacing-horizontal) * -1); | ||
| margin-inline-end: calc(var(--pico-block-spacing-horizontal) * -1); | ||
| padding: calc(var(--pico-block-spacing-vertical) * 0.66) var(--pico-block-spacing-horizontal); | ||
| background-color: var(--pico-card-sectioning-background-color); | ||
| } | ||
| article > header { | ||
| margin-top: calc(var(--pico-block-spacing-vertical) * -1); | ||
| margin-bottom: var(--pico-block-spacing-vertical); | ||
| border-bottom: var(--pico-border-width) solid var(--pico-card-border-color); | ||
| border-start-start-radius: var(--pico-border-radius); | ||
|
There was a problem hiding this comment. This might be confusing but ref. https://developer.mozilla.org/en-US/docs/Web/CSS/border-end-end-radius |
||
| border-start-end-radius: var(--pico-border-radius); | ||
| } | ||
| article > footer { | ||
| margin-top: var(--pico-block-spacing-vertical); | ||
|
|
@@ -2000,7 +1989,7 @@ details.dropdown > a::after { | |
| width: 1rem; | ||
| height: calc(1rem * var(--pico-line-height, 1.5)); | ||
| margin-inline-start: 0.25rem; | ||
| float: inline-start; | ||
| transform: rotate(0deg) translateX(0.2rem); | ||
| background-image: var(--pico-icon-chevron); | ||
| background-position: right center; | ||
|
|
@@ -2176,18 +2165,18 @@ label > details.dropdown { | |
| [role=group] > *:not(:first-child), | ||
| [role=group] input:not([type=checkbox], [type=radio]):not(:first-child), | ||
| [role=group] select:not(:first-child) { | ||
| margin-inline-start: 0; | ||
| border-start-start-radius: 0; | ||
| border-end-start-radius: 0; | ||
| } | ||
| [role=search] > *:not(:last-child), | ||
| [role=search] input:not([type=checkbox], [type=radio]):not(:last-child), | ||
| [role=search] select:not(:last-child), | ||
| [role=group] > *:not(:last-child), | ||
| [role=group] input:not([type=checkbox], [type=radio]):not(:last-child), | ||
| [role=group] select:not(:last-child) { | ||
| border-start-end-radius: 0; | ||
| border-end-end-radius: 0; | ||
| } | ||
| [role=search] > *:focus, | ||
| [role=search] input:not([type=checkbox], [type=radio]):focus, | ||
|
|
@@ -2211,7 +2200,7 @@ label > details.dropdown { | |
| [role=group] [role=button]:not(:first-child), | ||
| [role=group] input:not([type=checkbox], [type=radio]):not(:first-child), | ||
| [role=group] select:not(:first-child) { | ||
| margin-inline-start: calc(var(--pico-border-width) * -1); | ||
| } | ||
| [role=search] button, | ||
| [role=search] [type=submit], | ||
|
|
@@ -2266,12 +2255,12 @@ label > details.dropdown { | |
| } | ||
|
|
||
| [role=search] > *:first-child { | ||
| border-start-start-radius: 5rem; | ||
| border-end-start-radius: 5rem; | ||
| } | ||
| [role=search] > *:last-child { | ||
| border-start-end-radius: 5rem; | ||
| border-end-end-radius: 5rem; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -2355,20 +2344,20 @@ dialog article > header > * { | |
| } | ||
| dialog article > header .close, dialog article > header :is(a, button)[rel=prev] { | ||
| margin: 0; | ||
| margin-inline-start: var(--pico-spacing); | ||
| padding: 0; | ||
| float: inline-end; | ||
| } | ||
| dialog article > footer { | ||
| text-align: end; | ||
| } | ||
| dialog article > footer button, | ||
| dialog article > footer [role=button] { | ||
| margin-bottom: 0; | ||
| } | ||
| dialog article > footer button:not(:first-of-type), | ||
| dialog article > footer [role=button]:not(:first-of-type) { | ||
| margin-inline-start: calc(var(--pico-spacing) * 0.5); | ||
| } | ||
| dialog article .close, dialog article :is(a, button)[rel=prev] { | ||
| display: block; | ||
|
|
@@ -2394,7 +2383,7 @@ dialog:not([open]), dialog[open=false] { | |
| } | ||
|
|
||
| .modal-is-open { | ||
| padding-inline-end: var(--pico-scrollbar-width, 0px); | ||
| overflow: hidden; | ||
| pointer-events: none; | ||
| touch-action: none; | ||
|
|
@@ -2442,7 +2431,7 @@ dialog:not([open]), dialog[open=false] { | |
| * Nav | ||
| */ | ||
| :where(nav li)::before { | ||
| float: inline-start; | ||
| content: ""; | ||
| } | ||
|
|
||
|
|
@@ -2464,11 +2453,11 @@ nav ul { | |
| } | ||
| nav ol:first-of-type, | ||
| nav ul:first-of-type { | ||
| margin-inline-start: calc(var(--pico-nav-element-spacing-horizontal) * -1); | ||
| } | ||
| nav ol:last-of-type, | ||
| nav ul:last-of-type { | ||
| margin-inline-end: calc(var(--pico-nav-element-spacing-horizontal) * -1); | ||
| } | ||
| nav li { | ||
| display: inline-block; | ||
|
|
@@ -2490,9 +2479,8 @@ nav li [type=button], | |
| nav li input:not([type=checkbox], [type=radio], [type=range], [type=file]), | ||
| nav li select { | ||
| height: auto; | ||
| margin-bottom: 0; | ||
| margin-inline: inherit; | ||
| padding: calc(var(--pico-nav-link-spacing-vertical) - var(--pico-border-width) * 2) var(--pico-nav-link-spacing-horizontal); | ||
| } | ||
| nav[aria-label=breadcrumb] { | ||
|
|
@@ -2642,9 +2630,8 @@ progress::-moz-progress-bar { | |
| padding: 0; | ||
| transform: translate(-50%, 0rem); | ||
| border-top: 0.3rem solid; | ||
| border-radius: 0; | ||
| border-inline: 0.3rem solid transparent; | ||
| background-color: transparent; | ||
| content: ""; | ||
| color: var(--pico-tooltip-background-color); | ||
|
|
@@ -2681,7 +2668,7 @@ progress::-moz-progress-bar { | |
| [data-tooltip][data-placement=right]:after { | ||
| transform: translate(-0.3rem, -50%); | ||
| border: 0.3rem solid transparent; | ||
| border-inline-end: 0.3rem solid; | ||
| } | ||
| [data-tooltip]:focus::before, [data-tooltip]:focus::after, [data-tooltip]:hover::before, [data-tooltip]:hover::after { | ||
| opacity: 1; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*-rightand*-leftcan be merged into*-inline.