OpenEnergyMonitor request PID 2025 for emon #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Mar 25, 2024
|
Hi, here's the FW repo: https://github.com/awjlogan/emon32-fw Is there anything wrong with the Kicad files? |
|
Can this be merged? Thanks |
Thanks! Please link to it from the hardware repo. That way folks who follow the link from this repo can find it too. C source and license looks good.
Nope. Just a note to myself. |
|
Hi @tannewt - thanks for your time on this. I've added a link in the hardware repo to the firmware in commit 888aa99. Let me know if there's anything else that would be useful. |
tannewt
requested changes
Jun 4, 2024
glynhudson
changed the title
|
@tannewt no worries! I've updated this PR to request PID 2025 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.