Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/pingone_language_update: Add retry condition for language enabled race condition #884

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Jul 5, 2024

Change Description

  • Add retry condition for language enabled race condition
  • Bug: Fix "The language must be enabled before it is set as the default" error when setting a language as enabled and the environment default.

Required SDK Upgrades

Testing Shell Command

TF_ACC=1 go test -v -timeout 1200s -run ^TestAccLanguageUpdate_ github.com/pingidentity/terraform-provider-pingone/internal/service/base

Testing Results

Expand Results
=== RUN   TestAccLanguageUpdate_RemovalDrift
=== PAUSE TestAccLanguageUpdate_RemovalDrift
=== RUN   TestAccLanguageUpdate_Full
=== PAUSE TestAccLanguageUpdate_Full
=== RUN   TestAccLanguageUpdate_Minimal
=== PAUSE TestAccLanguageUpdate_Minimal
=== RUN   TestAccLanguageUpdate_SystemDefined
=== PAUSE TestAccLanguageUpdate_SystemDefined
=== RUN   TestAccLanguageUpdate_Change
=== PAUSE TestAccLanguageUpdate_Change
=== RUN   TestAccLanguageUpdate_BadParameters
=== PAUSE TestAccLanguageUpdate_BadParameters
=== CONT  TestAccLanguageUpdate_RemovalDrift
=== CONT  TestAccLanguageUpdate_SystemDefined
=== CONT  TestAccLanguageUpdate_Minimal
=== CONT  TestAccLanguageUpdate_BadParameters
=== CONT  TestAccLanguageUpdate_Change
=== CONT  TestAccLanguageUpdate_Full
--- PASS: TestAccLanguageUpdate_Minimal (43.85s)
--- PASS: TestAccLanguageUpdate_RemovalDrift (44.39s)
--- PASS: TestAccLanguageUpdate_Full (45.04s)
--- PASS: TestAccLanguageUpdate_BadParameters (45.88s)
--- PASS: TestAccLanguageUpdate_SystemDefined (67.16s)
--- PASS: TestAccLanguageUpdate_Change (76.50s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        78.167s

@patrickcping patrickcping added type/bug Something isn't working service/base PingOne Platform labels Jul 5, 2024
@patrickcping patrickcping added this to the v1.0.0-rc2 milestone Jul 5, 2024
@patrickcping patrickcping self-assigned this Jul 5, 2024
@patrickcping patrickcping marked this pull request as ready for review July 8, 2024 10:17
@patrickcping patrickcping requested a review from a team as a code owner July 8, 2024 10:17
@patrickcping patrickcping merged commit ff10442 into main Jul 8, 2024
14 checks passed
@patrickcping patrickcping deleted the fix-language-enabled-race-condition-error-202407 branch July 8, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/base PingOne Platform type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant