Make test.Bridge and packetio.Buffer compatible with net.Conn #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
force-pushed
the
net-conn-compatible-bridge-conn
branch
from
85891c6
to
9c24d40
Compare
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 83.01% 84.30% +1.28%
==========================================
Files 19 21 +2
Lines 1590 1727 +137
==========================================
+ Hits 1320 1456 +136
- Misses 181 183 +2
+ Partials 89 88 -1
Continue to review full report at Codecov.
|
at-wat
force-pushed
the
net-conn-compatible-bridge-conn
branch
from
9c24d40
to
9129722
Compare
|
@enobufs please take a look when you have time. |
at-wat
force-pushed
the
net-conn-compatible-bridge-conn
branch
from
9129722
to
1e6134f
Compare
at-wat
added a commit
to pion/dtls
that referenced
this pull request
Mar 15, 2020
at-wat
added a commit
to pion/dtls
that referenced
this pull request
Mar 15, 2020
at-wat
added a commit
to pion/dtls
that referenced
this pull request
Mar 16, 2020
at-wat
added a commit
to pion/dtls
that referenced
this pull request
Mar 17, 2020
|
Merging for now to proceed pion/dtls#226. |
Test bridgeConn by nettest.TestConn. Move github.com/pion/dtls/pkg/net/deadline to this package to implement full Read/WriteDeadline.
Support read timeout.
at-wat
force-pushed
the
net-conn-compatible-bridge-conn
branch
from
1e6134f
to
bbcc688
Compare
|
Great feature! Sorry for late! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57
Related to pion/dtls#208
dtls.Connnow supportsSetRead/WriteDeadlineif underlyingConnsupports them.I would also like to move
webrtc/internal/mux, which internally usepacketio.Buffer, to this package and add support ofSetRead/WriteDeadline.deadlinepackage is temporary duplicated withdtlspackage. I thinkpion/transportis a better place fordeadlinepackage.