Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tgyuu/#161 #162

Merged
merged 12 commits into from
Mar 25, 2024
Merged

Feature/tgyuu/#161 #162

merged 12 commits into from
Mar 25, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Mar 24, 2024

1. πŸ“„ κ΄€λ ¨λœ 이슈 및 μ†Œκ°œ

2. πŸ”₯ λ³€κ²½λœ 점

  • μŠ€ν”Œλž˜μ‰¬ μ• λ‹ˆλ©”μ΄μ…˜ μ†Œκ±°
  • SignIn -> Noticeν™”λ©΄μ—μ„œ λ„€λΉ„κ²Œμ΄μ…˜μ‹œ λ°±μŠ€ν…μ΄ λ‚¨μ•„μžˆλ˜ κ±° 발견 ν›„ μˆ˜μ •

3. βœ… κΌ­ ν™•μΈν•΄μ€¬μœΌλ©΄ ν•˜λŠ” λΆ€λΆ„

4. πŸ“Έ μŠ€ν¬λ¦°μƒ·(선택)

5. πŸ’‘μ•Œκ²Œλœ ν˜Ήμ€ κΆκΈˆν•œ 사항듀

@tgyuuAn tgyuuAn added πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ πŸ”₯ν•«ν”½μŠ€πŸ”₯ 릴리즈 ν›„ ν”„λ‘œλ•μ…˜ 레벨둜 올리기 μ „ μˆ˜μ •μž‘μ—… labels Mar 24, 2024
@tgyuuAn tgyuuAn requested a review from jeongjaino March 24, 2024 13:59
@tgyuuAn tgyuuAn self-assigned this Mar 24, 2024
@tgyuuAn tgyuuAn changed the base branch from main to develop March 24, 2024 13:59
@tgyuuAn tgyuuAn changed the base branch from develop to release March 24, 2024 15:01
@jeongjaino jeongjaino closed this Mar 25, 2024
@jeongjaino jeongjaino reopened this Mar 25, 2024
jeongjaino
jeongjaino approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM μž…λ‹ˆλ‹€ νƒœκ·œμƒ

μ œκ°€ μΆ”κ°€λ‘œ, GithubActionsμ΄λž‘ Gradle μ’€ μˆ˜μ •ν–ˆμ–΄μš”.

@jeongjaino jeongjaino added the πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. label Mar 25, 2024
@jeongjaino jeongjaino merged commit d9af2a9 into release Mar 25, 2024
@tgyuuAn tgyuuAn deleted the feature/tgyuu/#161 branch March 27, 2024 06:53
@tgyuuAn tgyuuAn mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. πŸ”₯ν•«ν”½μŠ€πŸ”₯ 릴리즈 ν›„ ν”„λ‘œλ•μ…˜ 레벨둜 올리기 μ „ μˆ˜μ •μž‘μ—… πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Splash μ• λ‹ˆλ©”μ΄μ…˜ 잠깐 μ†Œκ±°....!!!
2 participants
@tgyuuAn @jeongjaino