-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuring and adding sample widgets #18
Conversation
Added some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some notes.
General notes:
- It takes a lot of time to run
pip install -e "."
. At first, I thought my setup was stuck so I restarted it. (Windows 11 - wsl2). Maybe we can point it out. - I think
jlpm watch
is not working for me. Should it automatically rebuild the plugin after saving? Currently, I runjupyter lab
and on every change in the plugin's code, I restart the Kernel. - I wasn't able to run the tests:
-
I ran
nox --session test
- took ~50min to install the env and complete the tests. Logs and errors are attached:
nox-output.txt -
I ran
jlpm test
- after ~15 min it failed. Logs and errors are attached:
jlpm_test-output.txt -
After running each test, I ran
npx playwright show-report
and it showed nothing
-
good point. opened: #21 |
added a note
are you seeing new messages in the terminal? if so, it's working. if the change is in python, you need to restart the kernel (or use the IPython autoreload feature). If you change the frontend code, you need to refresh the browser tab.
could this be an OS issue? the command is running in the CI on mac and it works fine: jupysql-plugin/.github/workflows/ci.yaml Line 53 in fddbfba
I opened an issue so we test in other OSs: #19 |
we're gonna start building some widgets, this PR:
_widgets
private module)there are still a few pending improvements that I'll tackle in: #19