Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuring and adding sample widgets #18

Merged
merged 57 commits into from
May 30, 2023
Merged

configuring and adding sample widgets #18

merged 57 commits into from
May 30, 2023

Conversation

edublancas
Copy link
Contributor

@edublancas edublancas commented May 27, 2023

we're gonna start building some widgets, this PR:

  • the necessary configuration
  • added some basic tests
  • cleaned up README files
  • added two example widgets (in the _widgets private module)

there are still a few pending improvements that I'll tackle in: #19

@edublancas edublancas marked this pull request as ready for review May 27, 2023 14:47
@neelasha23
Copy link
Contributor

Added some comments.
We can add a developers guide that outlines the current scope, goals/ use cases, future work, etc.

Copy link
Contributor

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes.

General notes:

  1. It takes a lot of time to run pip install -e ".". At first, I thought my setup was stuck so I restarted it. (Windows 11 - wsl2). Maybe we can point it out.
  2. I think jlpm watch is not working for me. Should it automatically rebuild the plugin after saving? Currently, I run jupyter lab and on every change in the plugin's code, I restart the Kernel.
  3. I wasn't able to run the tests:
    • I ran nox --session test - took ~50min to install the env and complete the tests. Logs and errors are attached:
      nox-output.txt

    • I ran jlpm test - after ~15 min it failed. Logs and errors are attached:
      jlpm_test-output.txt

    • After running each test, I ran npx playwright show-report and it showed nothing
      image

jupysql_plugin/_widgets.py Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/version.ts Show resolved Hide resolved
ui-tests/README.md Show resolved Hide resolved
src/widgets/form.ts Show resolved Hide resolved
@edublancas
Copy link
Contributor Author

Added some comments. We can add a developers guide that outlines the current scope, goals/ use cases, future work, etc.

good point. opened: #21

@edublancas
Copy link
Contributor Author

Added some notes.

General notes:

1. It takes a lot of time to run `pip install -e "."`. At first, I thought my setup was stuck so I restarted it. (Windows 11 - wsl2). Maybe we can point it out.

added a note

2. I think `jlpm watch` is not working for me. Should it automatically rebuild the plugin after saving? Currently, I run `jupyter lab` and on every change in the plugin's code, I restart the Kernel.

are you seeing new messages in the terminal? if so, it's working. if the change is in python, you need to restart the kernel (or use the IPython autoreload feature). If you change the frontend code, you need to refresh the browser tab.

3. I wasn't able to run the tests:
   
   * I ran `nox --session test` - took ~50min to install the env and complete the tests. Logs and errors are attached:
     [nox-output.txt](https://github.com/ploomber/jupysql-plugin/files/11589813/nox-output.txt)
   * I ran `jlpm test` - after ~15 min it failed. Logs and errors are attached:
     [jlpm_test-output.txt](https://github.com/ploomber/jupysql-plugin/files/11589580/jlpm_test-output.txt)
   * After running each test, I ran `npx playwright show-report` and it showed nothing
     ![image](https://user-images.githubusercontent.com/103026689/241675922-29680cda-5ca6-481c-aa8a-6ed050c02449.png)

could this be an OS issue? the command is running in the CI on mac and it works fine:

nox --session test --no-install --reuse-existing-virtualenvs

I opened an issue so we test in other OSs: #19

@edublancas edublancas merged commit a705235 into main May 30, 2023
8 checks passed
@edublancas edublancas deleted the dev/widget branch May 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants