Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document running instructions for WMA #68

Open
wants to merge 9 commits into
base: wma800-corrections
Choose a base branch
from
Open

Document running instructions for WMA #68

wants to merge 9 commits into from

Conversation

tashrifbillah
Copy link
Contributor

No description provided.

RyanZurrin
RyanZurrin reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@RyanZurrin RyanZurrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

My only thoughts were where it mentioned to consult wm_apply_ORG_atlas_to_subject.sh --help for the meaning of arguments. It may be more user-friendly to also provide a brief summary of each argument directly in the README.

@tashrifbillah tashrifbillah added enhancement New feature or request future labels Oct 17, 2023
@tashrifbillah tashrifbillah temporarily deployed to github-pages October 20, 2023 20:14 — with GitHub Pages Inactive
@tashrifbillah
Copy link
Contributor Author

It may be more user-friendly to also provide a brief summary of each argument directly in the README.

Keeping this open. We shall look up to Ryan to implement his thoughts when he is more available.

@tashrifbillah
use -e flag to prevent supply of LC_ALL,LANG values
be770fb 
Fixes these warnings:
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
  LANGUAGE = (unset),
  LC_ALL = (unset),
  LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
Processing:..............................................Done
RyanZurrin
RyanZurrin reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@RyanZurrin RyanZurrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apptainer/singularity#744

They discuss some flags that are used besides the -e flag, so if for any reason the -e is not working there is also these to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZurrin RyanZurrin RyanZurrin left review comments

Assignees
No one assigned
Labels
enhancement New feature or request future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tashrifbillah @RyanZurrin