test: upgrade test-utils to latest version #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianhg
force-pushed
the
test/upgrade-test-utils
branch
from
ab3fc35
to
1618fb2
Compare
|
Thank you for this. I did go down the exact same path to try and silence this warning, and when I just ended up with all tests failing I decided to pause my efforts. But it's good to have an open PR for this so we can get it fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of filing #36, I ran the tests and saw there were some warnings about using the deprecated
actfrom the testing library. To silence this warning, I modified the code to import from react, but because the testing library is also internally callingactfromreact-dom, it still gave warnings.I looked through the
@testing-library/reactchange logs for the different major versions since the one we're currently on (13), and didn't see anything that looked too dangerous (see v14 + dom-testing-library@v9, v15 and v16).Interestingly, upgrading does silence the warnings, but yields errors in the tests. I don't know if these are actually real bugs or an issue with the tests, but I thought it would be worth raising a PR to highlight this and perhaps have you investigate!
For what its worth, it seems to be the upgrade to v14 (+ dom-testing-library@v9) that breaks the tests.