Use temp libpath in update script #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b158f9.
|
Thank you! Removed assets update for easy merge with other PRs |
schloerke
changed the title
schloerke
added a commit
that referenced
this pull request
Oct 31, 2023
* main: Use temp libpath in update script (#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to the
scripts/update_bootswatch.Rscript to use a temporary lib path for the entire operation --withr::local_libpaths()doesn't actually create a temp libpath, butwithr::local_temp_libpaths()does.The script now requires
withrbut is otherwise self-contained. I ran it again agains the bootstrap versions in main inpy-shinyand there were changes to the depdendencies, so I'm including those in this PR.