Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calloc calls #416

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fix calloc calls #416

merged 1 commit into from
Dec 26, 2023

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Apr 20, 2023

Size and number are switched in calloc sometimes. This PR fixes that.

@enaess
Copy link
Contributor

enaess commented Apr 23, 2023

These fixes look good.

@Neustradamus
Copy link
Member

@paulusmack: Have you seen this PR?

@Neustradamus
Copy link
Member

@paulusmack: Three month ago, @AtariDreams has done this PR, @enaess is okay, what do you think?

@enaess
Copy link
Contributor

enaess commented Jul 30, 2023

We should take this, code as is is using the calloc() api wrongly.

@paulusmack
Copy link
Collaborator

Hmmm... I would take it if the signoff wasn't a noreply.github.com address. Maybe it's trivial enough that that doesn't matter. In any case there is no functional problem here, given that the arguments are multiplied together and multiplication of integers is commutative.

@Neustradamus
Copy link
Member

@AtariDreams: Have you seen the @paulusmack comment?
What is the situation with your signoff?

@Neustradamus
Copy link
Member

@paulusmack: Have you seen the change from @AtariDreams?

@paulusmack
Copy link
Collaborator

@Neustradamus it's exactly the same change with the same noreply signoff, just rebased.

@Neustradamus
Copy link
Member

@AtariDreams: Can you add the correct sign-off?

@Neustradamus
Copy link
Member

@enaess: Can you look to do like previously?
Create a PR and sign the commit?

@Neustradamus
Copy link
Member

@paulusmack: You can not publish the PR directly with a note about @AtariDreams?

@AtariDreams
Copy link
Contributor Author

Fixed!

Size and number are switched in calloc sometimes. This PR fixes that.

Signed-off-by: Seija Kijin <[email protected]>
@paulusmack paulusmack merged commit 9ec68f3 into ppp-project:master Dec 26, 2023
25 checks passed
@Neustradamus Neustradamus removed the request for review from paulusmack December 26, 2023 19:32
@AtariDreams AtariDreams deleted the fix branch December 26, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants