Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ax_check_openssl with serial 11 from autoconf-archive #421

Closed
wants to merge 1 commit into from

Conversation

floppym
Copy link
Contributor

@floppym floppym commented May 2, 2023

The current macro checks ssldirs before calling pkg-config. This causes a build failure on multilib-enabled systems, since /usr/lib is searched before /usr/lib64.

The new macro calls pkg-config first, and only falls back to searching ssldirs if that fails.

Bug: https://bugs.gentoo.org/905442

The current macro checks ssldirs before calling pkg-config. This causes
a build failure on multilib-enabled systems, since /usr/lib is searched
before /usr/lib64.

The new macro calls pkg-config first, and only falls back to searching
ssldirs if that fails.

Bug: https://bugs.gentoo.org/905442
Signed-off-by: Mike Gilbert <[email protected]>
@floppym
Copy link
Contributor Author

floppym commented May 2, 2023

Hmm, upon further inspection, it looks like ppp's copy of ax_check_openssl.m4 has been customized to accept "yes" and "no" as valid arguments for --with-openssl. The pristine copy from autoconf-archive rejects these values.

Do you want to maintain this customization?

@floppym
Copy link
Contributor Author

floppym commented May 3, 2023

The ax_check_openssl.m4 code is actually pretty broken. Closing this until I can submit a better alternative.

@floppym floppym closed this May 3, 2023
@Neustradamus
Copy link
Member

@floppym: Do not hesitate to link your better alternative ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants