Use pkg-config to detect PAM when possible #479
Conversation
|
@paulusmack, @enaess: What do you think? |
|
I would like the commit message to have at least a sentence saying why this is a good thing and what will be the effect from the point of view of someone running ./configure. For example, are there now any new possibilities for options to ./configure, or do any existing options work any differently now? As for the substance of the change, I want to hear from @enaess . |
|
@paulusmack I updated the commit message with an explanation. |
|
@paulusmack: Have you seen @floppym changes? |
|
I'll have a look tomorrow, but also worth noting is that there are other ax_***.m4 files that use the same templated pattern. |
There was a problem hiding this comment.
Generally I am good with the idea of using pkg-config w/fallback of the hard-coded values in case pkg-config doesn't exist.
I'd additionally like to see similar change in the other .m4 files for pcap, atm, srp, and others to avoid the pam m4 file from deviating from the new "norm" if you like.
This fixes a link error on Gentoo Linux by not putting -L/usr/lib in the link command on 64-bit systems. The correct path is -L/usr/lib64, and this is the default path used by GCC and clang. Users may override pkg-config by setting PAM_CFLAGS and PAM_LDFLAGS in the environment before calling configure. This is standard behavior for the PKG_CHECK_MODULES macro. The legacy detection logic is maintained when a path is given as an argument to --with-pam. Note that this logic is broken when libdir is not "lib". Signed-off-by: Mike Gilbert <[email protected]>
I can sync things up in separate commits once the maintainers approve of what I have done with PAM. No sense in having me do a bunch of extra work if it will be rejected anyway. |
|
Could open an issue against the other .m4 files, but okay from me. |
This fixes a link error on Gentoo Linux by not putting -L/usr/lib in the
link command on 64-bit systems. The correct path is -L/usr/lib64, and
this is the default path used by GCC and clang.
Users may override pkg-config by setting PAM_CFLAGS and PAM_LDFLAGS in
the environment before calling configure. This is standard behavior for
the PKG_CHECK_MODULES macro.
The legacy detection logic is maintained when a path is given as an
argument to --with-pam. Note that this logic is broken when libdir is
not "lib".