PPPoE fixes and improvements #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 1c082ac ("pppoe: Show verbose information about all concentrator when pppoe-verbose option is set", 2021-01-01). That commit added a 5-second wait between receiving a valid PADO and sending the PADR response so as to give time to see whether any other PADOs arrive. However, it appears that this delay causes problems with some concentrators. This reverts to the previous behaviour of sending the PADR immediately. Signed-off-by: Paul Mackerras <[email protected]>
Reading the values of pppoe_padi_timeout and pppoe_padi_attempts in PPPOEInitDevice() means that they get sampled when the parsing the ethernet device name. If the user provides the pppoe-padi-attempts or pppoe-padi-timeout option after the ethernet device name, the value given is effectively ignored. Instead, read those variables in pppoe_check_options, which is called after all options have been parsed, so that any user-specified values don't get missed. Signed-off-by: Paul Mackerras <[email protected]>
This saves the access concentrator (AC) name supplied by the AC in the PADO packet and creates an environment variable called "ACNAME" with the name as its value for scripts to use if desired. This was inspired by a pull request from "bearmi" on github, but reimplemented somewhat differently by me. Signed-off-by: Paul Mackerras <[email protected]>
This was
linked to
issues
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert a previous commit by pali that seemed to be causing problems, and implement some minor improvements to PPPoE.