Validate user input for contact number

praekeltfoundation · Jul 10, 2023 · d606128 · d606128
1 parent 9435c1a
commit d606128
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/yal/tests/test_pleasecallme.py b/yal/tests/test_pleasecallme.py
@@ -941,3 +941,13 @@ async def state_state_specify_msisdn_invalid_input_with_plus(tester: AppTester):
     tester.assert_message(
         "\n".join(["⚠️ Please type a valid cell phone number.", "Example _081234567_"])
     )
+
+
+@pytest.mark.asyncio
+async def state_state_specify_msisdn_empty_input(tester: AppTester):
+    tester.setup_state("state_specify_msisdn")
+    await tester.user_input(None)
+    tester.assert_state("state_specify_msisdn")
+    tester.assert_message(
+        "\n".join(["⚠️ Please type a valid cell phone number.", "Example _081234567_"])
+    )
diff --git a/yal/validators.py b/yal/validators.py
@@ -39,7 +39,7 @@ async def validator(value):
 
 def phone_number_validator(error_text):
     async def validator(value):
-        if value.startswith("+") or value.isdigit():
+        if value:
             try:
                 normalise_phonenumber(value)
             except ValueError as e: