Merge pull request #709 from praekeltfoundation/endline_reminder

endline reminders
praekeltfoundation · Nov 14, 2023 · dc00cb0 · dc00cb0
2 parents 0866924 + f415c9f
commit dc00cb0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/yal/assessments.py b/yal/assessments.py
@@ -425,9 +425,11 @@ async def state_handle_assessment_reminder_response(self):
             return await self.go_to_state("state_reschedule_assessment_reminder")
 
         if inbound == "i m not interested":
-            assessment_name = ""
-            if "assessment_reminder_name" in self.user.metadata:
-                assessment_name = self.user.metadata["assessment_reminder_name"]
+            assessment_reminder_type = ""
+            if "assessment_reminder_type" in self.user.metadata:
+                assessment_reminder_type = self.user.metadata[
+                    "assessment_reminder_type"
+                ]
             data = {
                 "assessment_reminder_name": "",
                 "assessment_reminder_sent": "",
@@ -438,7 +440,7 @@ async def state_handle_assessment_reminder_response(self):
             if error:
                 return await self.go_to_state("state_error")
 
-            if "endline" in assessment_name:
+            if "endline" in assessment_reminder_type:
                 return await self.go_to_state("state_not_interested")
 
             return await self.go_to_state("state_pre_mainmenu")

diff --git a/yal/tests/test_assessments.py b/yal/tests/test_assessments.py
@@ -492,7 +492,7 @@ async def test_state_handle_assessment_reminder_response_not_interested_endline(
     tester: AppTester, contentrepo_api_mock, rapidpro_mock
 ):
     tester.user.metadata["assessment_reminder_sent"] = "True"
-    tester.user.metadata["assessment_reminder_name"] = "self_esteem_endline"
+    tester.user.metadata["assessment_reminder_type"] = "endline later 23hours"
     tester.setup_state("state_survey_question")
     await tester.user_input("I'm not interested")
     tester.assert_state("state_not_interested")