Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fix #655

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Validation fix #655

merged 5 commits into from
Aug 8, 2023

Conversation

Hlamallama
Copy link
Contributor

No description provided.

Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one question?

@@ -441,6 +441,15 @@ async def state_handle_assessment_reminder_response(self):
return await self.go_to_state("state_pre_mainmenu")

async def state_not_interested(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this state only used in the endline survey?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also used on the baseline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I guess its fine to update "endline_survey_started" to "" at that point too

@Hlamallama Hlamallama merged commit 5435178 into main Aug 8, 2023
1 check passed
@Hlamallama Hlamallama deleted the validation_fix branch August 8, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants