Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo4j Connector #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

vpawar-tibco
Copy link

Adding Neo4j Connector -

Features :

  • Neo4j Connection with NoAuth and BasicAuth Support.
  • Execute Cypher Query activity - supports MATCH, CREATE, MATCH-SET, MATCH-DETACH queries. allows yout to pass query parameters.
  • Unit tests added.

@flogo-oss
Copy link

flogo-oss commented Jul 2, 2020

CLA assistant check
All committers have signed the CLA.


//FromMap method
func (i *Input) FromMap(values map[string]interface{}) error {
i.CypherQuery, _ = coerce.ToString(values["cypherQuery"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nitpick, I think you should not ignore error here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you should probably just return the error if it is not nil.

  var err error
  i.CypherQuery, err = coerce.ToString(values["cypherQuery"])
  if err != nil {
    return err
  }

@skothari-tibco
Copy link
Contributor

Rest looks good.


//FromMap method
func (i *Input) FromMap(values map[string]interface{}) error {
i.CypherQuery, _ = coerce.ToString(values["cypherQuery"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you should probably just return the error if it is not nil.

  var err error
  i.CypherQuery, err = coerce.ToString(values["cypherQuery"])
  if err != nil {
    return err
  }

neo4j/activity/executeCypherQuery/metadata.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants