Remove application.js after bundle in template #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Jun 28, 2024
| @@ -21,9 +21,6 @@ def add_js_rails6 | |||
| def add_manifest | |||
| append_to_file 'app/assets/javascripts/application.js', "\n//= require_tree .\n" | |||
| append_to_file 'app/assets/config/manifest.js', "\n//= link spotlight/manifest.js" | |||
|
|
|||
| # Rails installed importmap by default, but we don't have importmap + Blacklight 7 working yet. | |||
| remove_file 'app/javascript/application.js' | |||
There was a problem hiding this comment.
Don't we need this even if we're not using the template? The use of template.rb is not required.
There was a problem hiding this comment.
I was assuming that for fresh Rails apps it still wouldn't do much because stimulus-rails would install after. For existing apps, it seemed slightly questionable to delete their application.js (even if it results in Spotlight not working). I haven't tested those assumptions yet, so I'm happy to leave the generator untouched and work toward getting the template instructions working as written.
taylor-steve
force-pushed
the
3014-remove-application-js
branch
from
23b25ad
to
37c5c83
Compare
taylor-steve
force-pushed
the
3014-remove-application-js
branch
from
37c5c83
to
4d9c462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #3014. I believe the
manifest.jsissue is fixed, but unreleased, in blacklight-gallery so that would still require manually fixing that newline if testing this for real.Moves the removal of
app/javascript/application.jsto the end of the end of the process. Steps that run after the install_generator, like stimulus-rails installing, recreate the file.https://github.com/hotwired/stimulus-rails/blob/ae4b675473b71fdf01530c8a6a3bb277d3388ee2/lib/install/stimulus_with_importmap.rb#L11