Wait for data to load in flappy test #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW these checks helped the tests pass for me locally. I had to add checks in a couple other places to get all the specs in that file to pass. |
|
Here's a draft PR with a similar set of changes that got the tests passing for me locally: #3041 |
taylor-steve
force-pushed
the
3039-flappy-tests
branch
from
674e911
to
a32e68f
Compare
|
@corylown I added the additional changes from your PR plus one in |
corylown
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around with solutions for #3039.
Trying to see if we can get Capybara to wait for the thumbnail.
Definitely seems to be load dependent. The tests get less flaky locally the further I get into Friday afternoon...