Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mesa.flat namespace #2091

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Remove mesa.flat namespace #2091

merged 1 commit into from
Jul 3, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Mar 27, 2024

This doesn't seem to be used as often as the current simple namespace.

@rht rht marked this pull request as ready for review March 27, 2024 08:28
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.8% [+0.6%, +1.0%] 🔵 -0.8% [-1.1%, -0.6%]
Schelling large 🔵 +1.3% [+0.6%, +1.9%] 🔵 -4.3% [-6.0%, -2.5%]
WolfSheep small 🔵 -0.3% [-0.9%, +0.4%] 🔵 -0.8% [-0.9%, -0.6%]
WolfSheep large 🔵 -0.5% [-1.0%, -0.1%] 🔵 -3.2% [-5.5%, -1.2%]
BoidFlockers small 🔵 -0.1% [-0.7%, +0.5%] 🔵 +1.8% [+1.2%, +2.4%]
BoidFlockers large 🔵 -0.1% [-0.8%, +0.5%] 🔵 +0.6% [-0.1%, +1.1%]

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.6% [-1.0%, -0.3%] 🔵 -2.0% [-2.5%, -1.5%]
Schelling large 🔵 -0.2% [-0.9%, +0.6%] 🔵 -2.5% [-5.6%, +0.8%]
WolfSheep small 🔵 -0.0% [-1.0%, +1.0%] 🔵 -1.2% [-1.5%, -1.0%]
WolfSheep large 🟢 -6.0% [-7.0%, -4.9%] 🟢 -19.7% [-21.6%, -17.6%]
BoidFlockers small 🔵 -0.6% [-1.2%, +0.2%] 🔵 -0.1% [-0.8%, +0.5%]
BoidFlockers large 🔵 -0.6% [-1.1%, -0.2%] 🔵 +0.1% [-0.6%, +0.9%]

@EwoutH
Copy link
Contributor

EwoutH commented Mar 27, 2024

Agreed, but I'm afraid this is a 3.0 ticked since it's breaking.

@EwoutH EwoutH added this to the [FUTURE] v3.0.0 milestone Mar 27, 2024
@EwoutH
Copy link
Contributor

EwoutH commented Apr 23, 2024

2.3 is released, so we can start with 3.0 development work, including moving this PR forward!

Maybe we should add a deprecation warning to 2.3.x though.

@rht
Copy link
Contributor Author

rht commented May 8, 2024

Can this be merged ASAP? This is a straightforward PR.

@EwoutH EwoutH added the breaking Release notes label label May 8, 2024
@EwoutH
Copy link
Contributor

EwoutH commented May 8, 2024

Can we add a deprecation message to the 2.3 branch?

@rht
Copy link
Contributor Author

rht commented May 8, 2024

I don't think anyone has ever used this namespace. It's not documented, and was already voted out in the past.

@EwoutH
Copy link
Contributor

EwoutH commented May 8, 2024

But adding a deprecation warning should be straightforward and is best practice.

@rht
Copy link
Contributor Author

rht commented May 11, 2024

Needs to fix the CI tests ASAP. The deprecation warning is not going to be a part of this PR. See #2133, which fixes the tests.

@EwoutH
Copy link
Contributor

EwoutH commented Jul 3, 2024

@rht I believe our CI is working again, could you rebase this PR?

This doesn't seem to be used as often as the current simple namespace.
@rht rht merged commit 0f3fe74 into projectmesa:main Jul 3, 2024
9 of 11 checks passed
@rht rht deleted the deprecate_flat branch July 3, 2024 10:42
@EwoutH
Copy link
Contributor

EwoutH commented Jul 3, 2024

Check green, thanks for this PR and merging!

vitorfrois pushed a commit to vitorfrois/mesa that referenced this pull request Jul 15, 2024
This doesn't seem to be used as often as the current simple namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants