Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit issues: Codespels and typecheck #2161

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix pre-commit issues: Codespels and typecheck #2161

merged 1 commit into from
Jul 3, 2024

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jul 3, 2024

Fixes two things pre-commit detected:

  • Some codespell errors
  • A case of E721 Use is and is not for type comparisons, or isinstance() for isinstance checks

After this PR all pre-commit checks are passing again.

@EwoutH EwoutH added the ignore-for-release PRs that aren't included in the release notes label Jul 3, 2024
@EwoutH EwoutH requested a review from rht July 3, 2024 10:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.9% [+0.6%, +1.2%] 🔵 +1.0% [+0.9%, +1.2%]
Schelling large 🔵 +0.5% [-0.5%, +1.4%] 🔵 +1.1% [+0.3%, +1.9%]
WolfSheep small 🔵 +0.5% [-0.6%, +1.7%] 🔵 +0.9% [+0.6%, +1.3%]
WolfSheep large 🔵 +0.5% [+0.3%, +0.8%] 🔵 +0.9% [+0.6%, +1.2%]
BoidFlockers small 🔵 +0.4% [-0.6%, +1.4%] 🔵 +1.9% [+1.1%, +2.7%]
BoidFlockers large 🔵 +1.2% [+0.5%, +1.9%] 🔵 +2.6% [+1.7%, +3.4%]

@EwoutH
Fix pre-commit issues: Codespel and typecheck
88bfc01 
Fixes two things pre-commit detected:
- Some codespell errors
- A case of E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
@rht rht merged commit f3f98ee into projectmesa:main Jul 3, 2024
9 of 11 checks passed
@EwoutH
Copy link
Contributor Author

EwoutH commented Jul 3, 2024

Thanks for merging!

@EwoutH EwoutH deleted the codespell-fix branch July 3, 2024 11:11
vitorfrois pushed a commit to vitorfrois/mesa that referenced this pull request Jul 15, 2024
@EwoutH @vitorfrois
Fix pre-commit issues: Codespel and typecheck (projectmesa#2161)
5694d54 
Fixes two things pre-commit detected:
- Some codespell errors
- A case of E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

Assignees
No one assigned
Labels
ignore-for-release PRs that aren't included in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EwoutH @rht