Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.NaN (deprecated in NumPy 2.0.0) with np.nan #1725

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

ibevers
Copy link
Contributor

@ibevers ibevers commented Jun 17, 2024

@egordorichev
Copy link

Ran into this issue ealier today, thanks for the pr!

@hbredin hbredin merged commit 50b21d4 into pyannote:develop Jun 19, 2024
4 checks passed
@hbredin
Copy link
Member

hbredin commented Jun 19, 2024

Thanks @ibevers! Will be part of next release!

@ibevers
Copy link
Contributor Author

ibevers commented Jun 20, 2024

Great! Glad to hear that!

@metal3d
Copy link
Contributor

metal3d commented Jun 26, 2024

It's actually wider...

 File "/XXX/venv/lib64/python3.12/site-packages/pyannote/audio/pipelines/speaker_diarization.py", lin
e 403, in reconstruct
    clustered_segmentations = np.NAN * np.zeros(
                              ^^^^^^
  File "/XXX/venv/lib64/python3.12/site-packages/numpy/__init__.py", line 410, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'NAN'. Did you mean: 'nan'?

metal3d added a commit to metal3d/pyannote-audio that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants