Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(attendee): add test cases for attendee apis #1146

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

Ritabear
Copy link
Contributor

@Ritabear Ritabear commented Jul 10, 2023

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)
    testing for attendee feat:attendee-app-unit-test #1142

Description

Describe what the change is
You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly
self-describe enough about how you change the code.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. You may also want to refer
to how to wirte the perfect pull request

@Ritabear Ritabear requested a review from josix July 10, 2023 10:16
@Ritabear Ritabear self-assigned this Jul 10, 2023
@mattwang44
Copy link
Member

CI 沒過要檢查一下 flake8 warnings

@Ritabear Ritabear requested a review from mattwang44 July 12, 2023 14:29
Comment on lines +9 to +12
('123', 400, 0),
('1234', 200, 0),
('1234', 200, 1),
('1234', 200, 2),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: it would be more meaningful for the real scenario if passing the fake data as the value of a token (i.e. 7521d8fa2ede2ecd4a77b5dgca1e921c)

@josix josix merged commit acf07f8 into master Jul 24, 2023
1 check passed
@mattwang44 mattwang44 deleted the test_attendee branch March 17, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants