feat(sponsor): add diamond level #1207
Conversation
| @@ -66,20 +66,22 @@ class Sponsor(ConferenceRelated): | |||
| ) | |||
|
|
|||
| class Level: | |||
| PLATINUM = 1 | |||
There was a problem hiding this comment.
DB 裡面存的是整數代號，對於舊資料來說這樣的改動會使其在 backend 所代表的意義不同（e.g. 某 sponsor 原為 gold 所以 sponsor.level 設定為 2，但這次改動後就變成 platinum），請思考一下該怎麼處理才能達成資料意義的一致性
There was a problem hiding this comment.
謝謝提醒！我把數值調回去並把鑽石設為0了（發現鑽石級設為num <=0 也可以達成同樣功能）
There was a problem hiding this comment.
nice job!
一般來說遇到這種情況就是盡量不要改動到現有資料使用到的代號（像你選擇的做法），如果真的非不得已需要改動的話，通常會把搬動資料的動作寫在 migration script 裡面（參考 Django 文件）
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 74.02% 74.03%
=======================================
Files 81 81
Lines 3061 3062 +1
=======================================
+ Hits 2266 2267 +1
Misses 795 795 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
這次改動邏輯並不複雜，希望能留單一一份 migration script 就好（可以刪掉兩份後重跑 makemigrations）
feat(sponsor): add diamond level fix(sponsor): adjust level for backward compatibility
SivanYeh
force-pushed
the
feat/sponsor-diamond
branch
from
90fb85b
to
0e6ad43
Compare
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesDescription
Add "Diamond" into sponsor levels in the backstage.
Steps to Test This Pull Request
Steps to reproduce the behavior:
Expected behavior
More Information
Discord message: https://discord.com/channels/752904426057892052/1231150103360835585/1266414865489330238